Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector Builder UI: Allow configuring cursor_datetime_format #28956

Closed
lmossman opened this issue Aug 1, 2023 · 1 comment
Closed

Connector Builder UI: Allow configuring cursor_datetime_format #28956

lmossman opened this issue Aug 1, 2023 · 1 comment
Assignees

Comments

@lmossman
Copy link
Contributor

lmossman commented Aug 1, 2023

Context

The FE side of #28782

This should look like a combobox that suggests common datetime formats, but it should allow multiple values to be entered, so we will need to modify our ComboBox component to support multiple values.

Whatever value the user puts there should be set as the cursor_datetime_format value in the converted manifest.

Acceptance Criteria

  • Users can configure cursor_datetime_format array in the Builder UI
  • Common datetime formats are still suggested
@lmossman
Copy link
Contributor Author

lmossman commented Aug 3, 2023

  • Don't support multiple values for now
  • Add an outgoing datetime format input to the Advanced section, make it optional, and if it is unset, just use the cursor datetime format as the outgoing datetime format in the manifest

@lmossman lmossman self-assigned this Aug 3, 2023
@lmossman lmossman closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant