From a622889ac11230159c89759c8c75c49ac883c5de Mon Sep 17 00:00:00 2001 From: Augustin Date: Fri, 24 May 2024 14:42:07 +0200 Subject: [PATCH] airbyte-ci: fix typo preventing secret mounting on python connectors for integration tests (#38645) --- airbyte-ci/connectors/pipelines/README.md | 3 ++- .../pipelines/pipelines/airbyte_ci/connectors/test/context.py | 1 - .../airbyte_ci/connectors/test/steps/python_connectors.py | 2 +- airbyte-ci/connectors/pipelines/pyproject.toml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/airbyte-ci/connectors/pipelines/README.md b/airbyte-ci/connectors/pipelines/README.md index be099d0ba4af..a978f8ebd052 100644 --- a/airbyte-ci/connectors/pipelines/README.md +++ b/airbyte-ci/connectors/pipelines/README.md @@ -748,7 +748,8 @@ E.G.: running Poe tasks on the modified internal packages of the current branch: | Version | PR | Description | | ------- | ---------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------- | -| 4.15.2 | [#38628](https://github.com/airbytehq/airbyte/pull/38628) | Introduce ConnectorTestContext to avoid trying fetching connector secret in the PublishContext. | +| 4.15.3 | [#38645](https://github.com/airbytehq/airbyte/pull/38645) | Fix typo preventing correct secret mounting on Python connectors integration tests. | +| 4.15.2 | [#38628](https://github.com/airbytehq/airbyte/pull/38628) | Introduce ConnectorTestContext to avoid trying fetching connector secret in the PublishContext. | | 4.15.1 | [#38615](https://github.com/airbytehq/airbyte/pull/38615) | Do not eagerly fetch connector secrets. | | 4.15.0 | [#38322](https://github.com/airbytehq/airbyte/pull/38322) | Introduce a SecretStore abstraction to fetch connector secrets from metadata files. | | 4.14.1 | [#38582](https://github.com/airbytehq/airbyte/pull/38582) | Fixed bugs in `up_to_date` flags, `pull_request` version change logic. | diff --git a/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/context.py b/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/context.py index 7ad665bd4fa1..0c358e08a2b7 100644 --- a/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/context.py +++ b/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/context.py @@ -99,7 +99,6 @@ def get_secrets_from_connector_test_suites_option( for secret_info in enabled_test_suite["testSecrets"]: if secret := ConnectorTestContext._process_secret(secret_info, secret_stores, raise_on_missing_secret_store, logger): secrets.append(secret) - return secrets def get_connector_secrets_for_test_suite( diff --git a/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/python_connectors.py b/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/python_connectors.py index 101b028b029b..a5aa433846a0 100644 --- a/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/python_connectors.py +++ b/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/python_connectors.py @@ -266,7 +266,7 @@ def get_test_steps(context: ConnectorTestContext) -> STEP_TREE: [ StepToRun( id=CONNECTOR_TEST_STEP_ID.INTEGRATION, - step=IntegrationTests(context, secrets=context.get_secrets_for_step_id(CONNECTOR_TEST_STEP_ID.UNIT)), + step=IntegrationTests(context, secrets=context.get_secrets_for_step_id(CONNECTOR_TEST_STEP_ID.INTEGRATION)), args=lambda results: {"connector_under_test": results[CONNECTOR_TEST_STEP_ID.BUILD].output[LOCAL_BUILD_PLATFORM]}, depends_on=[CONNECTOR_TEST_STEP_ID.BUILD], ), diff --git a/airbyte-ci/connectors/pipelines/pyproject.toml b/airbyte-ci/connectors/pipelines/pyproject.toml index 638ec93cc880..293641706ca8 100644 --- a/airbyte-ci/connectors/pipelines/pyproject.toml +++ b/airbyte-ci/connectors/pipelines/pyproject.toml @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api" [tool.poetry] name = "pipelines" -version = "4.15.2" +version = "4.15.3" description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines" authors = ["Airbyte "]