Skip to content

Commit 710698e

Browse files
committed
CDK: ref
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
1 parent d6eae14 commit 710698e

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

airbyte_cdk/sources/declarative/concurrent_declarative_source.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,6 @@ def _group_streams(
257257
stream_slicer=declarative_stream.retriever.stream_slicer,
258258
)
259259
else:
260-
# cursor: ConcurrentCursor
261260
if (
262261
incremental_sync_component_definition
263262
and incremental_sync_component_definition.get("type")

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1243,13 +1243,6 @@ def create_concurrent_cursor_from_incrementing_count_cursor(
12431243
)
12441244
cursor_field = CursorField(interpolated_cursor_field.eval(config=config))
12451245

1246-
# todo brian: what do we do about the state converter, is there a way to signal valid integer and what
1247-
# should the end provider be when the end time is an unknown uncapped value?
1248-
1249-
# hmmmmmm what if we create a new uncapped_end_date_provider which gives back infinite and that indicates
1250-
# to the concurrent cursor to return an empty slice interval and we create a connector_state_converter
1251-
# that basically just returns an integer
1252-
12531246
connector_state_converter = IncrementingCountStreamStateConverter(
12541247
is_sequential_state=True, # ConcurrentPerPartitionCursor only works with sequential state
12551248
)

0 commit comments

Comments
 (0)