Replace several autocorrectable SwiftLint rules with SwiftFormat rules #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Aug 16, 2024
| @@ -1,17 +1,12 @@ | |||
| only_rules: | |||
| - colon | |||
There was a problem hiding this comment.
Replaced by spaceAroundOperators
calda
commented
Aug 16, 2024
Comment on lines
-9
to
-10
| - operator_usage_whitespace | ||
| - return_arrow_whitespace |
There was a problem hiding this comment.
Replaced by spaceAroundOperators
calda
commented
Aug 16, 2024
| - fatal_error_message | ||
| - implicitly_unwrapped_optional | ||
| - legacy_cggeometry_functions | ||
| - legacy_constant | ||
| - legacy_constructor | ||
| - legacy_nsgeometry_functions | ||
| - operator_usage_whitespace | ||
| - return_arrow_whitespace | ||
| - trailing_newline |
There was a problem hiding this comment.
Replaced by lineBreakAtEndOfFile
calda
commented
Aug 16, 2024
| - unused_optional_binding | ||
| - vertical_whitespace |
There was a problem hiding this comment.
Replaced by consecutiveBlankLines
calda
force-pushed
the
cal--disable-swift-lint-rules
branch
from
a117786 to
d7c99c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are consolidating on using SwiftFormat for autocorrectable rules, and SwiftLint only for lint-only rules.
This PR replaces several autocorrectable SwiftLint rules with the corresponding SwiftFormat rule that implements the corresponding functionality.