Update colon spacing rule to apply to dictionary literals #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes updating the existing colon-spacing rule to also apply to dictionary literals. Previously, it applied to all usage of commas except dictionary literals.
Reasoning
It is much more common to omit the space before colon in dictionary literals. This also makes the rule more consistent and general.
This will also let us replace the SwiftLint
colon
rule with the SwiftFormatspaceAroundOperators
rule. The SwiftLint rule has aapply_to_dictionaries: false
option to exclude dictionary literals, but the SwiftFormat rule currently does not.