internal: Fix build based on changes.

Author: Miles Johnson

package.json

@@ -6,8 +6,8 @@
     "setup": "tsc --build && beemo create-config eslint prettier",
     "build": "beemo typescript --build --reference-workspaces",
     "clean": "rm -rf packages/*/{lib,*.tsbuildinfo}",
-    "test": "yarn run build && yarn run jest && yarn run eslint",
-    "eslint": "beemo eslint .",
+    "test": "yarn run build && yarn run jest && yarn run lint",
+    "lint": "beemo eslint .",
     "jest": "beemo jest",
     "prettier": "beemo prettier",
     "prerelease": "yarn run clean && yarn run test",

packages/config-webpack/package.json

@@ -44,6 +44,7 @@
     "webpack-graphql-loader": "^1.0.2"
   },
   "devDependencies": {
+    "@types/html-minifier-terser": "^5.0.0",
     "@types/html-webpack-plugin": "^3.2.2",
     "@types/terser-webpack-plugin": "^2.2.0",
     "@types/webpack-bundle-analyzer": "^2.13.3"

packages/config-webpack/src/index.ts

@@ -3,7 +3,6 @@
 import path from 'path';
 import webpack from 'webpack';
 import HtmlWebpackPlugin from 'html-webpack-plugin';
-// @ts-ignore Not typed
 import InlineManifestWebpackPlugin from 'inline-manifest-webpack-plugin';
 import TerserPlugin from 'terser-webpack-plugin';
 import { BundleAnalyzerPlugin } from 'webpack-bundle-analyzer';
@@ -51,7 +50,6 @@ export function getConfig({
     }),
     new HtmlWebpackPlugin({
       chunks: ['runtime', 'core'],
-      chunksSortMode: 'none',
       template: `${srcFolder}/index.html`,
       filename: 'index.html',
       favicon: getFavIcon(srcPath),

packages/nimbus/src/bins/eject.ts

@@ -3,7 +3,6 @@
 import fs from 'fs';
 import chalk from 'chalk';
 import execa from 'execa';
-// @ts-ignore Not typed
 import editJsonFile from 'edit-json-file';
 import { prompt } from 'enquirer';
 import { Path } from '@beemo/core';
@@ -28,8 +27,8 @@ async function copyAndInstallDepsFromModule(
   isYarn: boolean,
   isMonorepo: boolean,
 ) {
-  const pkg = require(`${moduleName}/package.json`);
-  const deps = Object.keys(pkg.dependencies).filter(
+  const pkg: NimbusPackage = require(`${moduleName}/package.json`);
+  const deps = Object.keys(pkg.dependencies || {}).filter(
     (dep) => !dep.includes('@beemo') && !dep.includes('@airbnb/nimbus'),
   );
 
@@ -75,7 +74,7 @@ function migrateDotfiles() {
 
 function migratePackageScripts(nimbus: NimbusPackage['nimbus']) {
   const pkg = editJsonFile(pkgPath);
-  const scripts = pkg.get('scripts') || {};
+  const scripts = pkg.get<NimbusPackage['scripts']>('scripts') ?? {};
   const srcFolder = nimbus.settings.srcFolder || 'src';
   const testFolder = nimbus.settings.testFolder || 'test';
 
@@ -142,7 +141,7 @@ function migrateEslint() {
 
 function migrateJest() {
   const configPath = Path.resolve('jest.config.js').path();
-  const config = require(configPath);
+  const config: { [key: string]: unknown } = require(configPath);
 
   delete config.moduleNameMapper;
   delete config.setupFiles;
@@ -184,7 +183,7 @@ export async function eject() {
   console.log(BANNER);
   console.log(`${chalk.cyan('[1/5]')} Ejecting Nimbus`);
 
-  const nimbus = editJsonFile(pkgPath).get('nimbus');
+  const nimbus = editJsonFile(pkgPath).get<NimbusPackage['nimbus']>('nimbus');
 
   if (!nimbus) {
     throw new Error("Project isn't Nimbus enabled.");

packages/nimbus/src/bins/setup.ts

@@ -1,6 +1,5 @@
 import chalk from 'chalk';
 import execa from 'execa';
-// @ts-ignore Not typed
 import editJsonFile from 'edit-json-file';
 import { prompt } from 'enquirer';
 import { Path } from '@beemo/core';
@@ -57,7 +56,7 @@ function addScriptsToPackage(response: SetupPrompt) {
   const pkg = editJsonFile(pkgPath);
   const client = response.yarn ? 'yarn' : 'npm';
   const monorepo = response.type === 'monolib';
-  const scripts = pkg.get('scripts') || {};
+  const scripts = pkg.get<NimbusPackage['scripts']>('scripts') ?? {};
 
   scripts.prepare = 'nimbus create-config --silent';
 

packages/nimbus/src/helpers/createGitHubClient.ts

@@ -1,4 +1,4 @@
-import Octokit from '@octokit/rest';
+import { Octokit } from '@octokit/rest';
 import { VERSION } from '../constants';
 
 export default function createGitHubClient(token?: string): Octokit {

packages/nimbus/src/scripts/AutoRelease.ts

@@ -1,4 +1,4 @@
-import { ExecaReturnValue } from 'execa';
+import { ExecaReturnValue, ExecaError } from 'execa';
 import { Script } from '@beemo/core';
 import { LERNA_VERSION_ARGS } from '../constants';
 
@@ -90,7 +90,7 @@ export default class AutoReleaseScript extends Script {
 
         return response;
       })
-      .catch((error) => {
+      .catch((error: ExecaError) => {
         this.tool.log.error(error.stderr);
 
         throw error;

packages/nimbus/src/scripts/PullRequestChecks.ts

@@ -1,6 +1,6 @@
 import path from 'path';
 import { Script } from '@beemo/core';
-import Octokit from '@octokit/rest';
+import { Octokit } from '@octokit/rest';
 import { checkCommitFormat } from 'conventional-changelog-beemo';
 import createGitHubClient from '../helpers/createGitHubClient';
 

types/edit-json-file.d.ts

@@ -0,0 +1,10 @@
+declare module 'edit-json-file' {
+  class Editor {
+    get<T = unknown>(key: string): T | undefined;
+    save(): void;
+    set<T = unknown>(key: string, value: T): void;
+    unset(key: string): void;
+  }
+
+  export default function editJsonFile(path: string): Editor;
+}

types/inline-manifest-webpack-plugin.d.ts

@@ -0,0 +1,5 @@
+declare module 'inline-manifest-webpack-plugin' {
+  export default class InlineManifestWebpackPlugin {
+    apply(): this;
+  }
+}