Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

png alpha dark outline #421

Closed
ghost opened this issue May 16, 2017 · 17 comments
Closed

png alpha dark outline #421

ghost opened this issue May 16, 2017 · 17 comments

Comments

@ghost
Copy link

ghost commented May 16, 2017

(Sorry if this is a repeat, couldn't find it in the search)

When png's are rendered they get a dark outline. This is especially noticeable when using blurry edges for an image.
boom_dark
alpha_blur

Seems like the export uses premultiplied using black? Changing the comp bg color doesn't make a difference.

Can we save them as "straight" alphas instead?
boom_correct
bluralpha_correct

It is possible to select this in the AE Render Settings/Output/Video Output/Color/Straight(Unmatted), but not in Bodymovin Render.

The only solution now is to resave the pngs from Photoshop.

@bigxixi
Copy link

bigxixi commented May 17, 2017

@themarten I try to change the way bodymovin render png, and it works fine for me:

  1. download this sourceHelper.jsx
    https://github.com/bigxixi/bodymovin-extension/raw/master/bundle/jsx/utils/sourceHelper.jsx

  2. goto the plugin folder and find the sourceHelper.jsx in
    WINDOWS:
    C:\Program Files (x86)\Common Files\Adobe\CEP\extensions\bodymovin\jsx\utils\ or
    C:\AppData\Roaming\Adobe\CEP\extensions\bodymovin\jsx\utils
    MAC:
    /Library/Application\ Support/Adobe/CEP/extensions/bodymovin/jsx/utils/

(or just search the name in your machine)

  1. back up the original sourceHelper.jsx , then replace it with the downloaded one.

  2. restart bodymovin and export your comp with png.

Hope that can help.

@ghost
Copy link
Author

ghost commented May 17, 2017

Thanks, but now the Bodymovin extension won't open in After Effects. The Extension is listed in the menu but when I click it no window shows up. Other extensions work fine. If I revert to the old file it works.

@bigxixi
Copy link

bigxixi commented May 17, 2017

@themarten sorry i havent test it on other machines.
try restart AE?

@ghost
Copy link
Author

ghost commented May 17, 2017

No luck. I restarted AE and reinstalled Bodymovin multiple times, tried the new and the old sourceHelper.jsx. I'm on a PC, Windows 10, latest After Effects CC 2017 and Bodymovin version. Any ideas?

@bigxixi
Copy link

bigxixi commented May 17, 2017

I am on Mac, AE CC2014, bodymovin 4.6.7, and works fine...

@ghost
Copy link
Author

ghost commented May 17, 2017

I'm using bodymovin 4.6.9 from 5 days ago.
Any chance you can try on a PC?

@bodymovin
Copy link
Collaborator

I think the issue is related to how you installed the plugin.
If you did it from the Adobe addons store, it seems to do some check on files and you can't modify them.
Regarding @bigxixi's solution, I'm trying to see how to add it to the project.
I've done some tests and it doesn't work well with CC 2014.
And also you need to tolerate the render chime going crazy if you have more than one asset :)

@ghost
Copy link
Author

ghost commented May 18, 2017

Right. I installed it using Anastasiy's Extension Manager (he makes Magpickpicker for Photoshop, the only way to install that extension) which has worked fine including the latest bodymovin.

Render chime? I have lots of assets.... Looking forward to hearing what "go crazy" means.

Thanks for looking into this. Very nice of both of you. Much appreciated.

@zmax91
Copy link

zmax91 commented Jun 5, 2017

@bigxixi your solution does not work for me, I'm using CC 2017 on Mac.
@bodymovin is there any way to fix this?

@machinefixer
Copy link

For mac user (I'm using macOS Sierra with AfterEffect CC 2017), just download modified version of bodymovin from @bigxixi 's repo: https://github.com/bigxixi/bodymovin, I installed it through ZXP Installer, replaced original bodymovin, then the black border is gone, everything comes great again.

@pegeseus
Copy link

Came here to ask the same question about the ability to use straight alpha. Has there been any progress on this? The workaround obviously is to export your own pngs with straight alpha and replace them in the folder but that gets tedious after a while. Thanks!

@bodymovin
Copy link
Collaborator

@pegeseus Hi, no progress yet.
But I'll be working on this soon.
Meanwhile, you can target another folder with your own pngs instead of replacing the ones on the images folder when you load the animation. So they don't get overwritten every time you export.

@bigxixi
Copy link

bigxixi commented Mar 26, 2018

I fixed the issue and pack the zxp myself:
https://github.com/bigxixi/bodymovin_fix/raw/master/bodymovin5.1.9_fixed.zxp
Download it and reinstall bodymovin, I use https://aescripts.com/learn/zxp-installer/
It works fine on my AE CC 2017 on MAC, and tested OK on some of my friends' PCs.
more details:
https://github.com/bigxixi/bodymovin_fix

@pegeseus
Copy link

Seems to work for me on Windows 7- good work! :D

@ghost
Copy link
Author

ghost commented Mar 28, 2018

Verified working on Windows 10. THANK YOU!

@rlxone
Copy link

rlxone commented Mar 28, 2018

@bigxixi
macOS High Sierra 10.13.4, AE CC 2017 - works fine. Thank you for your fix!

@IsMrWu
Copy link

IsMrWu commented Apr 23, 2018

@bigxixi perfect, it works on Window10,AE CC 2018 and Mac OS, AE CC 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants