Draft
Conversation
ljharb
requested changes
Aug 19, 2025
| "test": "npm run --silent test:config && npm run --silent test:config:base", | ||
| "test:config": "cd packages/eslint-config-airbnb; npm test", | ||
| "test:config:base": "cd packages/eslint-config-airbnb-base; npm test", | ||
| "test:config": "cd packages/eslint-config-airbnb && npm test", |
Collaborator
There was a problem hiding this comment.
why is this needed? cd should never fail regardless
| }, | ||
| "peerDependencies": { | ||
| "eslint": "^7.32.0 || ^8.2.0", | ||
| "eslint": "^9.8.0", |
Collaborator
There was a problem hiding this comment.
this is a breaking change. please limit yourself to things that work with eslint 7+.
| // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-curly-newline.md | ||
| 'react/jsx-curly-newline': ['error', { | ||
| // https://eslint.style/rules/jsx/jsx-curly-newline | ||
| '@stylistic/jsx/jsx-curly-newline': ['error', { |
Collaborator
There was a problem hiding this comment.
adding a new peer dep is a breaking change; we won't be doing that.
|
any news on this happening - this package is blocking our entire codebase form upgrading to eslint 9 :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the changes for ESLint 9.x branch compatibility.
Made all changes needed that I could find to run with new ESLint versions including removing some older packages and dependencies. Similarly some packages were added. Please see changes to see
package.jsonfiles.This maybe too large of a change and may need to be broken down further.
I was limited to Windows for testing.