Draft
Conversation
ljharb
requested changes
Dec 16, 2024
README.md
Outdated
Comment on lines
3187
to
3189
| export const MY_EXPORTED_FUNCTION = () => { | ||
| return 'hello function'; | ||
| }; |
Collaborator
There was a problem hiding this comment.
the indentation on this is incorrect, and there's no reason for this to be an arrow function, so it shouldn't be:
Suggested change
| export const MY_EXPORTED_FUNCTION = () => { | |
| return 'hello function'; | |
| }; | |
| export function MY_EXPORTED_FUNCTION() { | |
| return 'hello function'; | |
| }; |
but also this example has nothing to do with dangling commas, which is the section you've placed it in
Collaborator
There was a problem hiding this comment.
this still doesn't make any sense in this section.
Co-authored-by: Jordan Harband <ljharb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some changes such as-
export const MY_CONSTANT = 'should obviously not be uppercased' . In place of THING_TO_BE_CHANGED, it created unnecessary confusion as export const is not going to change across different files.
Another is an example of //good coding in README - export const MY_EXPORTED_FUNCTION = () => {
return 'hello function';
}; . As no example of this was already available in file.
Fixes #3032.