Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [connection] public API to retrieve peer address #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aniketh01
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #122 into main will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #122      +/-   ##
===========================================
- Coverage   100.00%   99.97%   -0.03%     
===========================================
  Files           24       24              
  Lines         4250     4252       +2     
===========================================
+ Hits          4250     4251       +1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/aioquic/quic/connection.py 99.91% <50.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50fb0f7...fa6579e. Read the comment docs.

@ahopkins
Copy link

ahopkins commented Dec 9, 2021

Why isn't this merged? What work is left? Just tests?

@jlaine
Copy link
Contributor

jlaine commented Dec 30, 2021

At first glance: tests, docstring for the new API.

What's not pleasant: we are arbitrarily returning the first network address. There may be others.

@ahopkins
Copy link

Maybe an API like this:

connection.peer_addresses.get()  # retrieves the first
connection.peer_addresses.getall()  # retrieves the list
connection.peer_address == connection.peer_addresses.get() 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants