Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed namedtuple Description #981

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

trim21
Copy link

@trim21 trim21 commented Mar 23, 2024

What do these changes do?

add a class Description(typing.NamedTuple) for cursor.description

Are there changes in behavior for the user?

yes, cursor.description now return a tuple[Description] instead of tuple[tuple[...]]

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.65%. Comparing base (83aa96e) to head (ed82a84).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
- Coverage   93.68%   93.65%   -0.03%     
==========================================
  Files          36       37       +1     
  Lines        5538     5550      +12     
  Branches      895      895              
==========================================
+ Hits         5188     5198      +10     
- Misses        260      262       +2     
  Partials       90       90              
Flag Coverage Δ
CI-GHA 93.26% <100.00%> (-0.03%) ⬇️
DB-mariadb-10.10 90.30% <100.00%> (+0.02%) ⬆️
DB-mariadb-10.11 90.30% <100.00%> (+0.02%) ⬆️
DB-mariadb-10.4 90.32% <100.00%> (+0.02%) ⬆️
DB-mariadb-10.5 90.30% <100.00%> (+0.02%) ⬆️
DB-mariadb-10.6 90.30% <100.00%> (+0.02%) ⬆️
DB-mariadb-10.9 90.30% <100.00%> (+0.02%) ⬆️
DB-mysql-5.7 91.00% <100.00%> (+0.01%) ⬆️
DB-mysql-8.0 92.39% <100.00%> (-0.02%) ⬇️
OS-Linux 93.26% <100.00%> (-0.03%) ⬇️
Py-3.10.11 ?
Py-3.10.13 93.17% <100.00%> (?)
Py-3.11.3 ?
Py-3.11.8 93.17% <100.00%> (?)
Py-3.7.16 ?
Py-3.7.17 92.80% <100.00%> (?)
Py-3.8.16 ?
Py-3.8.18 93.19% <100.00%> (?)
Py-3.9.16 ?
Py-3.9.18 93.03% <100.00%> (?)
VM-ubuntu-latest 93.26% <100.00%> (-0.03%) ⬇️
ubuntu-latest_3.10_mariadb-10.10 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.11 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.4 90.23% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.5 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.6 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.10_mariadb-10.9 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.10_mysql-5.7 90.91% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.10_mysql-8.0 92.30% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.11_mariadb-10.10 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.11_mariadb-10.11 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.11_mariadb-10.4 90.23% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.11_mariadb-10.5 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.11_mariadb-10.6 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.11_mariadb-10.9 90.21% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.11_mysql-5.7 90.91% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.11_mysql-8.0 92.30% <100.00%> (-0.02%) ⬇️
ubuntu-latest_3.7_mariadb-10.10 89.66% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.7_mariadb-10.11 89.66% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.7_mariadb-10.4 89.68% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.7_mariadb-10.5 89.66% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.7_mariadb-10.6 89.66% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.7_mariadb-10.9 89.66% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.7_mysql-5.7 90.41% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.7_mysql-8.0 91.88% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.10 90.25% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.11 90.25% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.4 90.27% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.5 90.25% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.6 90.25% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.8_mariadb-10.9 90.25% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.8_mysql-5.7 90.96% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.8_mysql-8.0 92.33% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.9_mariadb-10.10 90.09% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.11 90.09% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.4 90.11% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.5 90.09% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.6 90.09% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.9_mariadb-10.9 90.09% <100.00%> (+0.02%) ⬆️
ubuntu-latest_3.9_mysql-5.7 90.79% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.9_mysql-8.0 92.17% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trim21 trim21 changed the title Add namedtuple Description Add typed namedtuple Description Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant