Format status lines with f-strings #8846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added
backport-3.10
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #8846 +/- ##
==========================================
+ Coverage 98.14% 98.24% +0.09%
==========================================
Files 107 107
Lines 34067 34108 +41
Branches 4030 4050 +20
==========================================
+ Hits 33435 33508 +73
+ Misses 456 424 -32
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dreamsorcerer
approved these changes
Aug 23, 2024
webknjaz
approved these changes
Aug 23, 2024
|
Thanks for the 👀 |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8868 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
(cherry picked from commit 4dd8c80)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8869 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
(cherry picked from commit 4dd8c80)
bdraco
added a commit
that referenced
this pull request
Aug 23, 2024
bdraco
added a commit
that referenced
this pull request
Aug 23, 2024
…#8868) **This is a backport of PR #8846 as merged into master (4dd8c80).** <!-- Thank you for your contribution! --> ## What do these changes do? Format status lines with f-strings ## Are there changes in behavior for the user? no, maybe a tiny performance improvement ## Is it a substantial burden for the maintainers to support this? no Co-authored-by: J. Nick Koston <nick@koston.org>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Format status lines with f-strings
Are there changes in behavior for the user?
no, maybe a tiny performance improvement
Is it a substantial burden for the maintainers to support this?
no