Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AbstractMatchInfo with UrlMappingMatchInfo. #5328

Closed
wants to merge 17 commits into from
Closed

Replace AbstractMatchInfo with UrlMappingMatchInfo. #5328

wants to merge 17 commits into from

Conversation

Dreamsorcerer
Copy link
Member

Fixes #4748

If I understood the comment on that issue correctly, this is the change that should be made.

Dreamsorcerer
Dreamsorcerer commented Dec 9, 2020
View reviewed changes
aiohttp/web_urldispatcher.py
@@ -987,11 +987,11 @@ async def resolve(self, request: Request) -> AbstractMatchInfo:
return match_dict
else:
allowed_methods |= allowed

if allowed_methods:
return MatchInfoError(HTTPMethodNotAllowed(method, allowed_methods))
else:
Copy link
Member Author

@Dreamsorcerer Dreamsorcerer Dec 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped the else here, as it is redundant, and makes it a little more difficult to see that the function will always return.
(The diff is a little awkward to look at, as it's split it weirdly, but all I've done is remove the else following the for).

@codecov
Copy link

codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #5328 (268c575) into master (dab21a4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 268c575 differs from pull request most recent head 8cb4b6f. Consider uploading reports for the commit 8cb4b6f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5328   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files          44       44           
  Lines        9857     9857           
  Branches     1592     1592           
=======================================
  Hits         9537     9537           
  Misses        182      182           
  Partials      138      138
Flag Coverage Δ
unit 96.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_app.py 97.33% <100.00%> (ø)
aiohttp/web_middlewares.py 100.00% <100.00%> (ø)
aiohttp/web_urldispatcher.py 97.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab21a4...8cb4b6f. Read the comment docs.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 9, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 9, 2020

This pull request fixes 1 alert when merging 7cf6819 into cb4bae7 - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary 'else' clause in loop

@Dreamsorcerer Dreamsorcerer mentioned this pull request Sep 30, 2021
Merged
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 30, 2021

This pull request fixes 1 alert when merging 268c575 into dab21a4 - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary 'else' clause in loop

@asvetlov asvetlov added this to the 3.8 milestone Oct 1, 2021
@dependabot
Bump multidict from 5.1.0 to 5.2.0 (#96)
b498bea 
Bumps [multidict](https://github.com/aio-libs/multidict) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/aio-libs/multidict/releases)
- [Changelog](https://github.com/aio-libs/multidict/blob/master/CHANGES.rst)
- [Commits](aio-libs/multidict@v5.1.0...v5.2.0)

---
updated-dependencies:
- dependency-name: multidict
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 4, 2021

This pull request fixes 1 alert when merging b498bea into 3ae013e - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary 'else' clause in loop

@dependabot
Bump sqren/backport-github-action from 1.0.40 to 1.0.41 (#99)
4aea1c5 
Bumps [sqren/backport-github-action](https://github.com/sqren/backport-github-action) from 1.0.40 to 1.0.41.
- [Release notes](https://github.com/sqren/backport-github-action/releases)
- [Commits](sorenlouv/backport-github-action@v1.0.40...v1.0.41)

---
updated-dependencies:
- dependency-name: sqren/backport-github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 5, 2021

This pull request fixes 1 alert when merging 4aea1c5 into 1b4b89c - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary 'else' clause in loop

@dependabot
Bump coverage from 5.5 to 6.0.1 (#100)
a83ad03 
Bumps [coverage](https://github.com/nedbat/coveragepy) from 5.5 to 6.0.1.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@coverage-5.5...6.0.1)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump yarl from 1.6.3 to 1.7.0 (#101)
9ea5fbc 
Bumps [yarl](https://github.com/aio-libs/yarl) from 1.6.3 to 1.7.0.
- [Release notes](https://github.com/aio-libs/yarl/releases)
- [Changelog](https://github.com/aio-libs/yarl/blob/master/CHANGES.rst)
- [Commits](aio-libs/yarl@v1.6.3...v1.7.0)

---
updated-dependencies:
- dependency-name: yarl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 7, 2021

This pull request fixes 1 alert when merging 9ea5fbc into c9c9bec - view on LGTM.com

fixed alerts:

  • 1 for Unnecessary 'else' clause in loop

dependabot bot added 10 commits October 8, 2021 13:04
@dependabot
Bump multidict from 5.1.0 to 5.2.0 (#102)
4158576 
Bumps [multidict](https://github.com/aio-libs/multidict) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/aio-libs/multidict/releases)
- [Changelog](https://github.com/aio-libs/multidict/blob/master/CHANGES.rst)
- [Commits](aio-libs/multidict@v5.1.0...v5.2.0)

---
updated-dependencies:
- dependency-name: multidict
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump pytest-cov from 2.12.1 to 3.0.0 (#98)
8c5d641 
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.12.1 to 3.0.0.
- [Release notes](https://github.com/pytest-dev/pytest-cov/releases)
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v2.12.1...v3.0.0)

---
updated-dependencies:
- dependency-name: pytest-cov
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump flake8 from 3.9.2 to 4.0.0 (#103)
8aec754 
Bumps [flake8](https://github.com/pycqa/flake8) from 3.9.2 to 4.0.0.
- [Release notes](https://github.com/pycqa/flake8/releases)
- [Commits](PyCQA/flake8@3.9.2...4.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump coverage from 6.0.1 to 6.0.2 (#104)
185b9fa 
Bumps [coverage](https://github.com/nedbat/coveragepy) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@6.0.1...6.0.2)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump flake8 from 4.0.0 to 4.0.1 (#105)
900a502 
Bumps [flake8](https://github.com/pycqa/flake8) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/pycqa/flake8/releases)
- [Commits](PyCQA/flake8@4.0.0...4.0.1)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/checkout from 2.3.4 to 2.3.5 (#106)
e5c5cc7 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.4...v2.3.5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump frozenlist from 1.1.1 to 1.2.0 (#108)
92074f6 
Bumps [frozenlist](https://github.com/aio-libs/frozenlist) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/aio-libs/frozenlist/releases)
- [Changelog](https://github.com/aio-libs/frozenlist/blob/master/CHANGES.rst)
- [Commits](aio-libs/frozenlist@v1.1.1...v1.2.0)

---
updated-dependencies:
- dependency-name: frozenlist
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump frozenlist from 1.1.1 to 1.2.0 (#109)
e646fee 
Bumps [frozenlist](https://github.com/aio-libs/frozenlist) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/aio-libs/frozenlist/releases)
- [Changelog](https://github.com/aio-libs/frozenlist/blob/master/CHANGES.rst)
- [Commits](aio-libs/frozenlist@v1.1.1...v1.2.0)

---
updated-dependencies:
- dependency-name: frozenlist
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump aiosignal from 1.1.2 to 1.2.0 (#107)
34a7c7e 
Bumps [aiosignal](https://github.com/aio-libs/aiosignal) from 1.1.2 to 1.2.0.
- [Release notes](https://github.com/aio-libs/aiosignal/releases)
- [Changelog](https://github.com/aio-libs/aiosignal/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiosignal@v1.1.2...v1.2.0)

---
updated-dependencies:
- dependency-name: aiosignal
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump aiosignal from 1.1.2 to 1.2.0 (#110)
8cb4b6f 
Bumps [aiosignal](https://github.com/aio-libs/aiosignal) from 1.1.2 to 1.2.0.
- [Release notes](https://github.com/aio-libs/aiosignal/releases)
- [Changelog](https://github.com/aio-libs/aiosignal/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiosignal@v1.1.2...v1.2.0)

---
updated-dependencies:
- dependency-name: aiosignal
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@asvetlov asvetlov mentioned this pull request Oct 26, 2021
Merged
@asvetlov
Copy link
Member

Superseded by #6135

@asvetlov asvetlov closed this Oct 26, 2021
@patchback patchback bot mentioned this pull request Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

mypy AbstractMatchInfo has no attribute "route"
2 participants
@Dreamsorcerer @asvetlov