Fix bug in route name validation #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #5051 +/- ##
==========================================
- Coverage 97.60% 97.59% -0.02%
==========================================
Files 43 43
Lines 8953 8955 +2
Branches 1410 1411 +1
==========================================
+ Hits 8739 8740 +1
Misses 96 96
- Partials 118 119 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
* Fix bug in route name validation * Add changelog * Fix test end error msg * Add test
💚 Backport successfulThe PR was backported to the following branches:
|
asvetlov
pushed a commit
that referenced
this pull request
Oct 15, 2020
asvetlov
added a commit
that referenced
this pull request
Oct 16, 2020
* Fix bug in route name validation * Add changelog * Fix test end error msg * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4691
Co-Authored-By: gorogoroumaru force.minpiku@gmail.com