Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABCs should import from collections.abc in Py3.7+ #3275

Merged
merged 2 commits into from
Sep 18, 2018

Conversation

augustogoulart
Copy link
Contributor

@augustogoulart augustogoulart commented Sep 18, 2018

What do these changes do?

In Python 3.8, importing ABCs directly from the collections module will not be supported anymore.
The proposed changes will stop the current warnings for the users working with Python 3.7 and prevent backward incompatibility.

python/cpython#5460

Are there changes in behavior for the user?

No.

Related issue number

#3273

PR #3258 also fixed some imports.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@augustogoulart augustogoulart changed the title ABCs should import from collections.abc on Py3.7+ ABCs should import from collections.abc in Py3.7+ Sep 18, 2018
@asvetlov asvetlov merged commit 6b112b0 into aio-libs:master Sep 18, 2018
@asvetlov
Copy link
Member

thanks

@augustogoulart
Copy link
Contributor Author

My pleasure.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants