Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resources __repr__ formatting #2935

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Fix resources __repr__ formatting #2935

merged 1 commit into from
Apr 13, 2018

Conversation

vadim-su
Copy link
Contributor

What do these changes do?

Cosmetic change.
Now, when printing resources, they will have a closing bracket.

I broke my head reading this:

[<StaticResource 'debugtoolbar.static' /_debugtoolbar/static -> PosixPath('/usr/local/lib/python3.6/site-packages/aiohttp_debugtoolbar/static'), <PlainResource 'debugtoolbar.source'  /_debugtoolbar/source, <PlainResource 'debugtoolbar.execute'  /_debugtoolbar/execute, <PlainResource 'debugtoolbar.exception'  /_debugtoolbar/exception, <PlainResource 'debugtoolbar.sse'  /_debugtoolbar/sse, <DynamicResource 'debugtoolbar.request'  /_debugtoolbar/{request_id}, <PlainResource 'debugtoolbar.main'  /_debugtoolbar, <PlainResource  /users/, <DynamicResource  /users/{user_id}, <PlainResource  /login, <PlainResource  /whoami, <PlainResource  /cars/, <DynamicResource  /cars/{car_id}, <DynamicResource  /cars/{car_id}/upload_image, <PlainResource  /cars/search, <PlainResource  /cars/brands/, <PlainResource  /cars/types/]

@asvetlov
Copy link
Member

Would you add CHANGES note?

@codecov-io
Copy link

codecov-io commented Apr 13, 2018

Codecov Report

Merging #2935 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2935   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files          40       40           
  Lines        7513     7513           
  Branches     1318     1318           
=======================================
  Hits         7362     7362           
  Misses         48       48           
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd1185...88f445f. Read the comment docs.

@vadim-su
Copy link
Contributor Author

Made the required changes.
Updated the commit.

@asvetlov asvetlov merged commit 55a6782 into aio-libs:master Apr 13, 2018
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants