-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site and AppRunner #2530
Site and AppRunner #2530
Conversation
Can you give an example of how this would work and how it's better than the current situation? |
|
|
Codecov Report
@@ Coverage Diff @@
## master #2530 +/- ##
==========================================
+ Coverage 97.78% 97.87% +0.08%
==========================================
Files 36 38 +2
Lines 7236 7305 +69
Branches 1262 1263 +1
==========================================
+ Hits 7076 7150 +74
+ Misses 55 51 -4
+ Partials 105 104 -1
Continue to review full report at Codecov.
|
* Initial access_log_factory support. * Added changes. * abstraction level changes for AccessLogger. * Added RequestHandler docstrings. * Fix changes naming. * Added access_log_class check for Application.make_handler * Added basic tests for access_log_class. * Added docs for access_log_class * Fix typo request->response * _log -> log * Added more details to TypeError regarding access_log_class.
I'm going to merge the PR. Documentation is needed but I'll do it in separate PR. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
I'm trying to cleanup infrastructure for web application runners.
The PR introduces a
site
andAppRunner
concepts.Fixes #2121 and #2375
Supersedes #2465
The work is still not finished yet but I believe my intention is clear.