Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web protocol cleanup #2500

Merged
merged 4 commits into from
Nov 10, 2017
Merged

Web protocol cleanup #2500

merged 4 commits into from
Nov 10, 2017

Conversation

asvetlov
Copy link
Member

  • Drop deprecated param
  • Drop kwargs

@codecov-io
Copy link

codecov-io commented Nov 10, 2017 •
edited
Loading

Codecov Report

Merging #2500 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2500      +/-   ##
==========================================
- Coverage   97.14%   97.14%   -0.01%     
==========================================
  Files          39       39              
  Lines        8098     8095       -3     
  Branches     1416     1415       -1     
==========================================
- Hits         7867     7864       -3     
  Misses         99       99              
  Partials      132      132
Impacted Files Coverage Δ
aiohttp/web_protocol.py 88.05% <ø> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c578c03...c82cac3. Read the comment docs.

kxepal
kxepal reviewed Nov 10, 2017
View reviewed changes
aiohttp/web_protocol.py
@@ -94,11 +92,7 @@ def __init__(self, manager, *, loop=None,
max_headers=32768,
max_field_size=8190,
lingering_time=10.0,
max_concurrent_handlers=1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that an accidental removal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_concurrent_handlers is not removed, see below.
But **kwargs is dropped

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah! GitHub UI tricked me.

@asvetlov asvetlov merged commit 3c1746d into master Nov 10, 2017
@asvetlov asvetlov deleted the web-protocol branch November 10, 2017 10:14
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kxepal kxepal kxepal approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asvetlov @codecov-io @kxepal