Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect warning in StreamReader. #2251

Merged
merged 2 commits into from
Sep 8, 2017

Conversation

roganov
Copy link
Contributor

@roganov roganov commented Sep 7, 2017

What do these changes do?

I was getting a random warning when using request.multipart() concerning EOF state of StreamReader, though I was making exactly one read() for every BodyPartReader. The issue was that unread_data wasn't resetting _eof_counter.

Are there changes in behavior for the user?

No

Checklist

  • [+ ] I think the code is well written
  • [+] Unit tests for the changes exist
  • [+] Documentation reflects the changes
  • [+] If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • [+] Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Sep 7, 2017

Codecov Report

Merging #2251 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2251      +/-   ##
=========================================
+ Coverage    97.2%   97.2%   +<.01%     
=========================================
  Files          39      39              
  Lines        7945    7946       +1     
  Branches     1378    1378              
=========================================
+ Hits         7723    7724       +1     
  Misses         98      98              
  Partials      124     124
Impacted Files Coverage Δ
aiohttp/streams.py 99.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c1237...739b1c1. Read the comment docs.

@asvetlov asvetlov changed the base branch from 2.2 to master September 8, 2017 08:22
@asvetlov asvetlov merged commit bb3b091 into aio-libs:master Sep 8, 2017
@asvetlov
Copy link
Member

asvetlov commented Sep 8, 2017

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants