Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor named routes #179

Merged
merged 1 commit into from
Nov 28, 2014
Merged

Refactor named routes #179

merged 1 commit into from
Nov 28, 2014

Conversation

asvetlov
Copy link
Member

Second try to bring up route names.
Solution solves only UrlDispatcher requests, other implementations may have another public API.
Entry converted to Route with PlainRoute, DynamicRoute and StaticRoute descendants.
UrlDispatcher is a Mapping with __getitem__ and other required methods.

@fafhrd91 thoughts?

@fafhrd91
Copy link
Member

lgtm

asvetlov added a commit that referenced this pull request Nov 28, 2014
@asvetlov
Merge pull request #179 from KeepSafe/named_routes
ec67f8d 
Refactor named routes
@asvetlov asvetlov merged commit ec67f8d into master Nov 28, 2014
@asvetlov asvetlov deleted the named_routes branch November 28, 2014 08:03
@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asvetlov @fafhrd91