-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix zstd decompression for chunked zstd response #11623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11623 +/- ##
==========================================
+ Coverage 98.19% 98.74% +0.55%
==========================================
Files 128 127 -1
Lines 43757 43448 -309
Branches 2384 2326 -58
==========================================
- Hits 42965 42903 -62
+ Misses 610 389 -221
+ Partials 182 156 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11623 will not alter performanceComparing Summary
Footnotes |
Backport to 3.13: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply df8ad83 on top of patchback/backports/3.13/df8ad83efdd33408db2803cbd4a50be45422b74f/pr-11623 Backporting merged PR #11623 into master
🤖 @patchback |
Backport to 3.14: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply df8ad83 on top of patchback/backports/3.14/df8ad83efdd33408db2803cbd4a50be45422b74f/pr-11623 Backporting merged PR #11623 into master
🤖 @patchback |
|
Think you could handle those backports? |
(cherry picked from commit df8ad83)
(cherry picked from commit df8ad83)
|
@Dreamsorcerer backports: |
… zstd response (#11624)
… zstd response (#11625)
To avoid issue resolved by aio-libs/aiohttp#11623 while waiting for release with fix
What do these changes do?
The changes fix the decompression of chunked zstd streams.
Are there changes in behavior for the user?
Previously, on chunked zstd streams, aiohttp would crash with
zstandard.backend_c.ZstdError: could not determine content size in frame headerorzstd.ZstdError: decompression error: did not decompress full frame.Now it doesn't.
Related issue number
#11604 tries to fix the same issue, but there's no corresponding GitHub issue opened yet.
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.