-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Content-Type to application/octet-stream by default #1124
Conversation
@asvetlov Just saw the failing tests. Sorry about that. |
@@ -774,7 +774,7 @@ def __init__(self, *, body=None, status=200, | |||
self.set_tcp_cork(True) | |||
|
|||
if body is not None and text is not None: | |||
raise ValueError("body and text are not allowed together.") | |||
raise ValueError('body and text are not allowed together') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use "
for exception messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the difference in quotes usage was due to different contributors. I'll change it back
Please don't forget about:
|
Current coverage is 98.15% (diff: 100%)@@ master #1124 diff @@
==========================================
Files 28 28
Lines 6387 6391 +4
Methods 0 0
Messages 0 0
Branches 1073 1074 +1
==========================================
+ Hits 6269 6273 +4
Misses 63 63
Partials 55 55
|
Thanks! |
Related issue number
#944
Checklist