-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations everywhere, help needed #3293
Comments
GitMate.io thinks possibly related issues are #3230 (iter_chunks type annotation wrong), #1181 (Provide MacOSX binary wheels. Help needed!), #3240 (Missing type annotations in pyi files), #2041 (File external links, help needed), and #2395 (Convert autodoc for multipart into written docs, help needed). |
Supersedes #1749 |
@asvetlov If I want to contribute to this, which PR should I use? |
aiohttp master branch as usual. |
Hint: |
|
Finished |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
I'm working on adding type hints.
The hints are useless until their correctness is checked by
mypy
in strong mode.The problem is: enabling the mode for the whole codebase generates too many errors.
Basically, it is the all-or-nothing situation.
The plan is: let's convert file by file.
To enable strong mode please uncomment mypy options from the settings file: https://github.com/aio-libs/aiohttp/blob/master/setup.cfg#L42-L48
Before submitting a Pull Request please make sure that uncommented config is not landed (revert settings back).
The job is trivial but requires updating too many source code lines, that's why I need a help from the community. Even small PRs are valuable.
The text was updated successfully, but these errors were encountered: