Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientResponse.content protocol #106

Closed
kxepal opened this issue Jul 8, 2014 · 3 comments
Closed

ClientResponse.content protocol #106

kxepal opened this issue Jul 8, 2014 · 3 comments
Labels
outdated

Comments

@kxepal
Copy link
Member

kxepal commented Jul 8, 2014

Looks like I'd introduced another bug (: Currently, ClientResponse.release expect that underlying flow control implements .readany() method. However, recently introduced FlowControlChunksQueue doesn't.

I wonder what the fix have to be: readany() for ChunksQueue is mostly useless while making his read() to match the behaviour of StreamReader is almost dangerous. What's the common baseline would be for both of these?
@fafhrd91
Copy link
Member

fafhrd91 commented Jul 8, 2014

lets just make alias readany() for read()

@kxepal
Copy link
Member Author

kxepal commented Jul 8, 2014

Good idea. Done in #107

@fafhrd91 fafhrd91 closed this as completed Jul 8, 2014
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fafhrd91 @kxepal