Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicAuth bugged ? #103

Closed
trecouvr opened this issue Jul 7, 2014 · 3 comments
Closed

BasicAuth bugged ? #103

trecouvr opened this issue Jul 7, 2014 · 3 comments
Labels

Comments

@trecouvr
Copy link

trecouvr commented Jul 7, 2014

Hi,

I have trouble performing an authenticated request. I sniffed the traffic with tcpdump and discovered the authorization header is not sent.
I think the auth parameter (https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/client.py#L38) is not used in the request method during the instanciation of the request_class (https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/client.py#L96).

The change seems to have been introduced in 50a95fb.

@fafhrd91
Copy link
Member

fafhrd91 commented Jul 7, 2014

oh! good catch!

@asvetlov
Copy link
Member

asvetlov commented Jul 7, 2014

Fixed in 1b15ffa

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants