Skip to content

Updated versions of underlying dependencies #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Updated versions of underlying dependencies #60

merged 1 commit into from
Apr 28, 2025

Conversation

pjoshi30
Copy link
Contributor

All tests pass except for the low level tests

====================================== short test summary info ======================================
FAILED test_low_level_api.py::TestLowLevelAPIWithRealService::test_user_validate - Failed: User validation failed: <!doctype html>
FAILED test_low_level_api.py::TestLowLevelAPIWithRealService::test_user_validate_invalid_key - AssertionError: assert 404 == 401
FAILED test_low_level_api.py::TestLowLevelAPIWithRealService::test_application_create_retrieve_delete - Failed: Application creation failed: assert None == 'test_ll_1745869627_model'
FAILED test_low_level_api.py::TestLowLevelAPIWithRealService::test_evaluation_create_retrieve - Failed: Evaluation retrieval failed: 'EvaluationRetrieveResponseItem' object has no attribute 'id'
FAILED test_low_level_api.py::TestLowLevelAPIWithRealService::test_evaluation_run_create - Failed: Evaluation run creation failed: assert 118 == '118'
FAILED test_low_level_api.py::TestLowLevelAPIWithRealService::test_inference_detect - Failed: Inference detect failed: assert False
============================= 6 failed, 27 passed, 7 warnings in 46.61s =============================

@pjoshi30 pjoshi30 requested a review from alexlyzhov April 28, 2025 19:53
devvratbhardwaj
devvratbhardwaj approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@devvratbhardwaj devvratbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !!

Version bumped ✅
Dependencies upgraded ✅
A new datetime parsing function to comply with Pydantic ✅
String type conversion to avoid Pydantic warnings ✅

@pjoshi30 pjoshi30 merged commit 43112bb into main Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devvratbhardwaj devvratbhardwaj devvratbhardwaj approved these changes

@alexlyzhov alexlyzhov Awaiting requested review from alexlyzhov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjoshi30 @devvratbhardwaj