Ch 24 - Add edge detection section #177
Conversation
jasmaa
changed the title
1-Introduction/index.html
Outdated
| @@ -6,9 +6,9 @@ | |||
| <script src="http://code.jquery.com/jquery-1.12.4.js"></script> | |||
| <script type="text/javascript" src="../main.js"></script> | |||
| </head> | |||
| <body> | |||
| <body class="flex-content-container"> | |||
There was a problem hiding this comment.
To keep this PR self contained to chapter 24, lets remove this change.
| For many of us, it is easy to find both the objects in a picture and their boundaries. Humans are | ||
| very good at identifying what something is and where it is given a clear line of sight, but what if | ||
| we need to find the boundaries of many objects in an enormously large number photos? While we could | ||
| put a room full of toddlers with markers at work and tell them to outline the edges in a stack of |
There was a problem hiding this comment.
The reference to toddlers and morals is unnecessary. Lets rephrase this without them.
There was a problem hiding this comment.
I'd have this paragraph as:
For many of us, it is easy to find both the objects in a picture and their boundaries. Humans are very good at identifying what something is and where it is given a clear line of sight, but what if we need to find the boundaries of many objects in an enormously large number of photos? In computer vision, this is a general problem known as edge detection.
| <h2>Image Representation</h2> | ||
|
|
||
| <p> | ||
| Before jumping into edge detection, we still need to do a little work with images. Computers |
There was a problem hiding this comment.
I'd rephrease hits as:
"Before jumping into edge detection, lets first go over how computers represent images."
header.html
Outdated
| </ul> | ||
| </li> | ||
| <li class="dropdown"> | ||
| <a class="dropdown-toggle" data-toggle="dropdown" href="#">Part 6 | ||
| <span class="caret"></span></a> | ||
| <ul class="dropdown-menu"> | ||
| <li><a href="../22-Natural-Language-Processing">22. Natural Language Processing</a></li> |
There was a problem hiding this comment.
Why is this needed? Having the relative URLs help us decouple this from deployment?
There was a problem hiding this comment.
I removed this when I split the section into two pages originally. Relative url assumes we only inject the header in pages one directory down which breaks links if we try to add more pages per section. Some operations in my section require the site to be on a server to work so we can't really avoid decoupling...
styles.css
Outdated
| @@ -33,3 +33,45 @@ pre{ | |||
| body > div.row { | |||
| margin-right: 0px; | |||
| } | |||
|
|
|||
| .flex-content-container { | |||
There was a problem hiding this comment.
I'm concerned about these global changes ... have you tested the rest of the pages with this?
There was a problem hiding this comment.
CSS here is mainly so it can trickle down through multiple directories for my section and for potential future use in other pages. The classes are currently not used in other pages.
There was a problem hiding this comment.
can't it be included only in your chapter directory then (e.g. overriding the main css)?
1-Introduction/index.html
Outdated
| @@ -7,7 +7,7 @@ | |||
| <script type="text/javascript" src="../main.js"></script> | |||
| </head> | |||
| <body> | |||
|
|
|||
styles.css
Outdated
| @@ -33,3 +33,45 @@ pre{ | |||
| body > div.row { | |||
| margin-right: 0px; | |||
| } | |||
|
|
|||
| .flex-content-container { | |||
There was a problem hiding this comment.
can't it be included only in your chapter directory then (e.g. overriding the main css)?
main.js
Outdated
| @@ -15,18 +15,53 @@ | |||
| $(function() { | |||
| var body = document.getElementsByTagName('body')[0]; | |||
|
|
|||
| // Inject breadcrumbs | |||
There was a problem hiding this comment.
I'm concerned about global changes here ... can't this be moved to your page only?
No description provided.