Use only one global var for marking config folder tree

[unkcpz]

The problem is found when I worked on #6609. If the import of DAEMON_DIR moved to outside the function, the global var set in module scope and in test contest will not be reset when function is loading.

The goal for a better design is to reduce the use of global variable. Now it is only the glb_aiida_config_folder (the original AIIDA_CONFIG_FOLDER). Other three are derived from this one. This lower the possibility of directly access the global variable without noticing its change.

• use a class to derive daemon dir and daemon log dir instead of using 4 global vars.
• Remove usage daemon dir, log dir, access control dir from other modules.

[codecov]

Codecov Report

Attention: Patch coverage is 95.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.91%. Comparing base (ef60b66) to head (95e305c).
Report is 133 commits behind head on main.

Files with missing lines	Patch %	Lines
src/aiida/cmdline/commands/cmd_profile.py	0.00%	2 Missing ⚠️
src/aiida/manage/tests/pytest_fixtures.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6610      +/-   ##
==========================================
+ Coverage   77.51%   77.91%   +0.41%     
==========================================
  Files         560      567       +7     
  Lines       41444    42161     +717     
==========================================
+ Hits        32120    32846     +726     
+ Misses       9324     9315       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[GeigerJ2]

If basedpyright is happy with the code, there is probably nothing I can add :D
Looks good to me! Just a few minor comments.

[danielhollas]

Maybe I am missing something but why not keep the current name? It would be more consistent with the other global vars above, and would reduce the diff in this PR significantly.

Suggested change

	glb_aiida_config_folder: pathlib.Path = pathlib.Path(DEFAULT_AIIDA_PATH).expanduser() / DEFAULT_CONFIG_DIR_NAME
	AIIDA_CONFIG_FOLDER: pathlib.Path = pathlib.Path(DEFAULT_AIIDA_PATH).expanduser() / DEFAULT_CONFIG_DIR_NAME

[unkcpz]

Because it is not a constant but a variable. I simply want to distinguish it from real constants above. It is also from pyright regards it as an type error.

[danielhollas]

I don't think I agree with this, it is still a constant semantically, it's just being computed from other constants at import time.

I don't think we should change code just because (some) LSP complains. What exactly is pyright complaining about? It's certainly not a type error, perhaps we're just not adhering to pyrights naming standards?

Also I guess using pyright here is not ideal since we're using mypy as a type checker, so you'll be constantly fighting the differences in behaviour between them.

[unkcpz]

But it is still not a constant but a global variable. It escape from the module scope anyway.
The name is changed with underscore in front to be only used for the module.

[unkcpz]

Suggested change

	return os.path.join(str(get_configuration_directory()), DEFAULT_CONFIG_FILE_NAME)
	return os.path.join(get_configuration_directory(), DEFAULT_CONFIG_FILE_NAME)