Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

Commit 3d3ae3d

Browse files
fix: preserve stream parameter in CompletionRequest (#47)
### Problem The `stream` parameter was omitted from requests, causing unexpected streaming behavior. ### Fix Ensured the `stream` parameter is preserved in CompletionRequest and ChatCompletionRequest. ### Tests Added unit tests to verify that the `stream` parameter is respected for both `true` and `false` values. Closes #46
1 parent 5669e6a commit 3d3ae3d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/main/java/dev/ai4j/openai4j/DefaultOpenAiClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public DefaultOpenAiClient build() {
132132
@Override
133133
public SyncOrAsyncOrStreaming<CompletionResponse> completion(OpenAiClientContext context,
134134
CompletionRequest request) {
135-
CompletionRequest syncRequest = CompletionRequest.builder().from(request).stream(null).build();
135+
CompletionRequest syncRequest = CompletionRequest.builder().from(request).stream(false).build();
136136

137137
return new RequestExecutor<>(
138138
openAiApi.completions(context.headers(), syncRequest, apiVersion),
@@ -150,7 +150,7 @@ public SyncOrAsyncOrStreaming<CompletionResponse> completion(OpenAiClientContext
150150
public SyncOrAsyncOrStreaming<String> completion(OpenAiClientContext context, String prompt) {
151151
CompletionRequest request = CompletionRequest.builder().prompt(prompt).build();
152152

153-
CompletionRequest syncRequest = CompletionRequest.builder().from(request).stream(null).build();
153+
CompletionRequest syncRequest = CompletionRequest.builder().from(request).stream(false).build();
154154

155155
return new RequestExecutor<>(
156156
openAiApi.completions(context.headers(), syncRequest, apiVersion),
@@ -167,7 +167,7 @@ public SyncOrAsyncOrStreaming<String> completion(OpenAiClientContext context, St
167167
@Override
168168
public SyncOrAsyncOrStreaming<ChatCompletionResponse> chatCompletion(OpenAiClientContext context,
169169
ChatCompletionRequest request) {
170-
ChatCompletionRequest syncRequest = ChatCompletionRequest.builder().from(request).stream(null).build();
170+
ChatCompletionRequest syncRequest = ChatCompletionRequest.builder().from(request).stream(false).build();
171171

172172
return new RequestExecutor<>(
173173
openAiApi.chatCompletions(context.headers(), syncRequest, apiVersion),
@@ -185,7 +185,7 @@ public SyncOrAsyncOrStreaming<ChatCompletionResponse> chatCompletion(OpenAiClien
185185
public SyncOrAsyncOrStreaming<String> chatCompletion(OpenAiClientContext context, String userMessage) {
186186
ChatCompletionRequest request = ChatCompletionRequest.builder().addUserMessage(userMessage).build();
187187

188-
ChatCompletionRequest syncRequest = ChatCompletionRequest.builder().from(request).stream(null).build();
188+
ChatCompletionRequest syncRequest = ChatCompletionRequest.builder().from(request).stream(false).build();
189189

190190
return new RequestExecutor<>(
191191
openAiApi.chatCompletions(context.headers(), syncRequest, apiVersion),

0 commit comments

Comments
 (0)