Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action to replace Travis CI #318

Merged
merged 2 commits into from
May 16, 2024
Merged

GitHub Action to replace Travis CI #318

merged 2 commits into from
May 16, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 11, 2024

Test results: https://github.com/cclauss/python-magic/actions

The Python 3.13 release notes mention python-magic as one of the alternatives for imghdr which was removed from the Standard Library so let's ensure that its tests pass on Python 3.13 beta.

https://www.python.org/downloads/release/python-3130b1/

May raise ModuleNotFoundError: No module named 'imghdr' because Python 3.13 removes it from the Standard Library.

imghdr: use the projects filetype, puremagic, or python-magic instead. (Contributed by Victor Stinner in gh-104773.)

https://docs.python.org/3.13/whatsnew/3.13.html#pep-594-dead-batteries-and-other-module-removals

cclauss added a commit to cclauss/python-magic that referenced this pull request May 16, 2024
As discussed at ahupp#317 (comment) this file is useless without a paid subscription to Travis CI.

GitHub Actions is free to open source projects but Travis CI is not.
*  ahupp#318
@cclauss cclauss mentioned this pull request May 16, 2024
ahupp pushed a commit that referenced this pull request May 16, 2024
As discussed at #317 (comment) this file is useless without a paid subscription to Travis CI.

GitHub Actions is free to open source projects but Travis CI is not.
*  #318
@cclauss
Copy link
Contributor Author

cclauss commented May 16, 2024

@ahupp Your review, please. It would help to have automated tests running.

Copy link
Owner

@ahupp ahupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahupp ahupp merged commit ab1b2a4 into ahupp:master May 16, 2024
@cclauss cclauss deleted the patch-2 branch May 16, 2024 16:06
@@ -157,6 +161,8 @@ def test_descriptions(self):
finally:
del os.environ["TZ"]

# TODO: Fix this failing test on Ubuntu
@pytest.mark.skipif(sys.platform == "linux", reason="'JSON data' not found")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, pytest was completely green for most linux architectures when running pytest using the cibuildwheel mechanism ref #294 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to create a targeted fix for #321?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was nothing to fix, pytest was green out of the box 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe because im building and bundling latest libmagic from source, and github ubuntu comes with an old libmagic?

cclauss added a commit to cclauss/python-magic that referenced this pull request May 20, 2024
As discussed at ahupp#317 (comment) this file is useless without a paid subscription to Travis CI.

GitHub Actions is free to open source projects but Travis CI is not.
*  ahupp#318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants