Skip to content

Commit 62b5a35

Browse files
pks-tgitster
authored andcommitted
fetch-pack: optimize loading of refs via commit graph
In order to negotiate a packfile, we need to dereference refs to see which commits we have in common with the remote. To do so, we first look up the object's type -- if it's a tag, we peel until we hit a non-tag object. If we hit a commit eventually, then we return that commit. In case the object ID points to a commit directly, we can avoid the initial lookup of the object type by opportunistically looking up the commit via the commit-graph, if available, which gives us a slight speed bump of about 2% in a huge repository with about 2.3M refs: Benchmark #1: HEAD~: git-fetch Time (mean ± σ): 31.634 s ± 0.258 s [User: 28.400 s, System: 5.090 s] Range (min … max): 31.280 s … 31.896 s 5 runs Benchmark #2: HEAD: git-fetch Time (mean ± σ): 31.129 s ± 0.543 s [User: 27.976 s, System: 5.056 s] Range (min … max): 30.172 s … 31.479 s 5 runs Summary 'HEAD: git-fetch' ran 1.02 ± 0.02 times faster than 'HEAD~: git-fetch' In case this fails, we fall back to the old code which peels the objects to a commit. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 9fec7b2 commit 62b5a35

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

fetch-pack.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,11 @@ static struct commit *deref_without_lazy_fetch(const struct object_id *oid,
119119
{
120120
enum object_type type;
121121
struct object_info info = { .typep = &type };
122+
struct commit *commit;
123+
124+
commit = lookup_commit_in_graph(the_repository, oid);
125+
if (commit)
126+
return commit;
122127

123128
while (1) {
124129
if (oid_object_info_extended(the_repository, oid, &info,

0 commit comments

Comments
 (0)