Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on camlp-streams makes atdgen-runtime unusable with OCaml < 5.00 #305

Open
Lupus opened this issue Jun 28, 2022 · 3 comments
Open

Dependency on camlp-streams makes atdgen-runtime unusable with OCaml < 5.00 #305

Lupus opened this issue Jun 28, 2022 · 3 comments

Comments

@Lupus
Copy link

Lupus commented Jun 28, 2022

See this commit in opam repo ocaml/opam-repository@a18b040

Does atdgen-runtime really need this dependency? Our CI is in ruins right now...
@Lupus
Copy link
Author

Lupus commented Jun 28, 2022

Also see ocaml/opam-repository#21656 (review)

@Lupus
Copy link
Author

Lupus commented Jun 28, 2022

Turns out camlp-streams 5.0.1 has old version constraint for all OCaml versions, while the 5.0.0 was modified in-place in the opam repo, destroying CI for customers in production. May be this extra depedency can still be dropped? atdgen is not using camlp4/5 it seems?

@rr0gi
Copy link

rr0gi commented Jun 29, 2022

#299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lupus @rr0gi