feat(auth): session fallback upgrade (swev-id: django__django-16631)#515
Open
casey-brooks wants to merge 1 commit intodjango__django-16631from
Open
feat(auth): session fallback upgrade (swev-id: django__django-16631)#515casey-brooks wants to merge 1 commit intodjango__django-16631from
casey-brooks wants to merge 1 commit intodjango__django-16631from
Conversation
Author
|
Tests & Lint Summary:
|
noa-lucent
approved these changes
Dec 24, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for documenting the default test site; matches current post_syncdb behavior.
Author
Test & Lint Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Observed Failure (pre-fix)
Reproduction Steps
django__django-16631without this patch.tests/auth_tests/test_session_auth_hash_fallbacks.pyfrom this branch.PYTHONPATH=$PWD .venv/bin/python tests/runtests.py auth_tests.test_session_auth_hash_fallbacks --parallel=1.Fix Summary
SECRET_KEYandSECRET_KEY_FALLBACKSwhen using the defaultAbstractBaseUser.get_session_auth_hashimplementation._auth_user_hashunder the active secret.SESSION_AUTH_HASH_KEY_SALTfor reuse across fallback validation.Testing
PYTHONPATH=$PWD .venv/bin/python tests/runtests.py auth_tests --parallel=1.venv/bin/flake8 django/contrib/auth/__init__.py django/contrib/auth/base_user.py tests/auth_tests/test_session_auth_hash_fallbacks.pyCI