Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume that typing_extensions is always installed. #487

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

thetorpedodog
Copy link
Contributor

Changes

Because we strictly depend upon typing_extensions both explicitly and implicitly, we don't need the code which checks if it isn't installed.

(This is a precursor to work on #479)

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • [n/a] You've added tests (in tests/) added which would fail without your patch
  • [n/a] You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • [n/a] You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Because we strictly depend upon typing_extensions both explicitly
and implicitly, we don't need the code which checks if it isn't installed.
@coveralls
Copy link

Coverage Status

coverage: 94.341% (+0.2%) from 94.139%
when pulling e23091a on thetorpedodog:always-typing-extensions
into 016f813 on agronholm:master.

@agronholm agronholm merged commit 2c035b3 into agronholm:master Sep 21, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants