Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scikit-build-core #62

Open
agriyakhetarpal opened this issue Mar 22, 2024 · 3 comments
Open

Use scikit-build-core #62

agriyakhetarpal opened this issue Mar 22, 2024 · 3 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request packaging infrastructure Releases, installation, etc.

Comments

@agriyakhetarpal
Copy link
Owner

Can specify everything from what to include in the sdist and wheel and things like ABI tags through declarative metadata – will be pretty cool

It will also help removing eggs from the sdist, which I'm not sure why they're there – note to self: return to https://github.com/agriyakhetarpal/hugo-python-distributions/tree/create-cleaner-sdist sometime soon

@agriyakhetarpal agriyakhetarpal added enhancement New feature or request packaging infrastructure Releases, installation, etc. dependencies Pull requests that update a dependency file labels Mar 23, 2024
@agriyakhetarpal
Copy link
Owner Author

scikit-build-core does not offer overriding invoking CMake behaviour. There are workarounds though: https://github.com/FMalerba/skbuild_test/tree/solution

Closing because it does not make sense to make things overly difficult to contribute further to and this project does not need CMake hacks. Perhaps hatch would fix all its issues if it can provide build_ext and bdist_wheel behaviours.

@agriyakhetarpal agriyakhetarpal closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
@agriyakhetarpal agriyakhetarpal added won't fix This will not be worked on and removed enhancement New feature or request packaging infrastructure Releases, installation, etc. dependencies Pull requests that update a dependency file labels Mar 24, 2024
@agriyakhetarpal
Copy link
Owner Author

Still in scope via overrides

@agriyakhetarpal agriyakhetarpal removed the won't fix This will not be worked on label Jul 27, 2024
@agriyakhetarpal
Copy link
Owner Author

agriyakhetarpal commented Jul 27, 2024

https://scikit-build-core.readthedocs.io/en/latest/plugins/hatchling.html
https://scikit-build-core.readthedocs.io/en/latest/plugins/setuptools.html

Need to configure a pre-installation step that builds the binary and places it in the installation directory and then the other build backend can take care of the rest

@agriyakhetarpal agriyakhetarpal added enhancement New feature or request packaging infrastructure Releases, installation, etc. dependencies Pull requests that update a dependency file labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request packaging infrastructure Releases, installation, etc.
Projects
None yet
Development

No branches or pull requests

1 participant