Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Commit f8b8533

Browse files
authored
proper S3 object handling (#97)
1 parent 76fae63 commit f8b8533

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version=2.2.15
1+
version=2.2.16
22
awsJavaSdkVersion=1.11.500
33
awsKinesisClientVersion=1.8.5
44
gradleWrapperVersion=3.4.1

grails-aws-sdk-s3/grails-app/services/grails/plugin/awssdk/s3/AmazonS3Service.groovy

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,10 +470,11 @@ class AmazonS3Service implements InitializingBean {
470470
String destinationBucketName,
471471
String destinationKey
472472
) {
473+
S3Object object
473474
try {
474475
CopyObjectRequest request = new CopyObjectRequest(sourceBucketName, sourceKey, destinationBucketName, destinationKey)
475476

476-
S3Object object = client.getObject(sourceBucketName, sourceKey)
477+
object = client.getObject(sourceBucketName, sourceKey)
477478

478479
if (object.taggingCount) {
479480
GetObjectTaggingRequest taggingRequest = new GetObjectTaggingRequest(sourceBucketName, sourceKey)
@@ -494,6 +495,8 @@ class AmazonS3Service implements InitializingBean {
494495
} catch (AmazonClientException e) {
495496
log.error("Exception moving object $sourceBucketName/$sourceKey to $destinationBucketName/$destinationKey", e)
496497
return null
498+
} finally {
499+
object?.close()
497500
}
498501
}
499502

0 commit comments

Comments
 (0)