added complete unit tests

Author: jamesvidler

package-lock.json

@@ -4,7 +4,7 @@
   "description": "JavaScript library for the Agility Fetch API (node and browser)",
   "main": "dist/agility-content-fetch.node.js",
   "scripts": {
-    "test": "mocha --require @babel/register --recursive ./test",
+    "test": "nyc --reporter=html --reporter=text mocha --require @babel/register --recursive ./test",
     "generate-docs": "node_modules/.bin/jsdoc --configure .jsdoc.json --verbose",
     "build": "webpack --config webpack.config -p"
   },
@@ -29,6 +29,7 @@
     "chai": "^4.2.0",
     "jsdoc": "^3.5.5",
     "mocha": "^6.0.2",
+    "nyc": "^13.3.0",
     "webpack": "^4.29.6",
     "webpack-cli": "^3.2.3"
   },

package.json

@@ -12,8 +12,7 @@ const defaultConfig = {
     instanceID: null,
     accessToken: null,
     languageCode: null
-}
-
+};
 
 export default function createClient(userConfig) {
 
@@ -24,6 +23,7 @@ export default function createClient(userConfig) {
     };
 
     function makeRequest(reqConfig) {
+        
         return axios(reqConfig).then(response => {
             return response.data;
         });   
@@ -39,6 +39,4 @@ export default function createClient(userConfig) {
         getPage: getPage
     }
 
-}
-
-
+}

src/api-client.js

@@ -49,13 +49,13 @@ function validateConfigParams(configParams) {
     if(!configParams.instanceID || configParams.instanceID.length == 0) {
         throw new TypeError('You must provide an instanceID');
     }
-
-    if(!configParams.accessToken || configParams.accessToken.length == 0) {
+    else if(!configParams.accessToken || configParams.accessToken.length == 0) {
         throw new TypeError('You must provide an access token');
     }
-
-    if(!configParams.languageCode || configParams.languageCode.length == 0) {
+    else if(!configParams.languageCode || configParams.languageCode.length == 0) {
         throw new TypeError('You must provide a language code');
+    } else {
+        return;
     }
 }
 

src/content-fetch.js

@@ -46,6 +46,8 @@ function getContentItem(requestParams) {
 function validateRequestParams(requestParams) {
     if(!requestParams.contentID) {
         throw new TypeError('You must include a contentID number in your request params.');
+    } else {
+        return;
     }
 }
 

src/methods/getContentItem.js

@@ -46,6 +46,8 @@ function getContentList(requestParams) {
 function validateRequestParams(requestParams) {
     if(!requestParams.referenceName) {
         throw new TypeError('You must include a content referenceName in your request params.');
+    } else {
+        return;
     }
 }
 

src/methods/getContentList.js

@@ -46,6 +46,8 @@ function getPage(requestParams) {
 function validateRequestParams(requestParams) {
     if(!requestParams.pageID) {
         throw new TypeError('You must include a pageID in your request params.');
+    } else {
+        return;
     }
 }
 

src/methods/getPage.js

@@ -46,6 +46,8 @@ function getSitemapFlat(requestParams) {
 function validateRequestParams(requestParams) {
     if(!requestParams.channelID) {
         throw new TypeError('You must include a channelID in your request params.');
+    } else {
+        return;
     }
 }
 

src/methods/getSitemapFlat.js

@@ -32,7 +32,9 @@ function getSitemapNested(requestParams) {
     validateRequestParams(requestParams);
 
     const req = {
-        url: `/Sitemap/Nested/${requestParams.channelID}`,
+        //HACK
+        //url: `/Sitemap/Nested/${requestParams.channelID}`,
+        url: `/Sitemap/Nested`,
         method: 'get',
         baseURL: utils.buildRequestUrlPath(this.config),
         headers: utils.buildAuthHeader(this.config),