deps: move peer types to optional peerDeps #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `react` and `prop-types` are peerDeps, so their `@types/` packages should be too - and since they're peers now, we can [mark them as optional](https://docs.npmjs.com/cli/v11/configuring-npm/package-json#peerdependenciesmeta) as well (since they're only needed for TS usage) - this should also allow for users to be able to install a range of `@types/react` as well, instead of just v19
This comment was marked as resolved.
This comment was marked as resolved.
agilgur5
commented
Feb 15, 2025
|
agilgur5
added
the
scope: dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
@types/reactand@types/prop-typestooptionalpeerDependenciesDetails
reactandprop-typesare peerDeps, so their@types/packages should be too@types/reactas well, instead of just v19@types/package not compatible with React 19 types #117 (comment)Future Work
This is in preparation for the v1.1.0 TS release (TypeScript Rewrite #42)