Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: agilgur5/react-signature-canvas
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: agilgur5/react-signature-canvas
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cra-example
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 13 files changed
  • 1 contributor

Commits on May 1, 2019

  1. (change): have gh-pages branch use the actual NPM package

    - easier to use this branch as a stepping stone to add to one's own
      codebase
    - also allows troubleshooting of issues with the current package
      without needing a build (that might accidentally differ slightly
      from the published version during development)
    
    - delete code that isn't associated with the example from this branch
      - and make package "private" so it's not published
    agilgur5 committed May 1, 2019
    Configuration menu
    Copy the full SHA
    f970e1b View commit details
    Browse the repository at this point in the history
  2. (change): serve HTML from root of repo

    - GitHub Pages loads from index.html in root of repo
    - also edit webpack-dev-server config to load from root too
    agilgur5 committed May 1, 2019
    Configuration menu
    Copy the full SHA
    2686571 View commit details
    Browse the repository at this point in the history
  3. (change): add bundle to source so GH pages can use it

    - ha, right that's pretty important
    agilgur5 committed May 1, 2019
    Configuration menu
    Copy the full SHA
    e4ded84 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2019

  1. (change): use CRA for example and CodeSandbox usage

    - CodeSanbox currently only works with CRA for browser sandboxes
    
    changes necessary for CRA (or makes CRA support simpler):
    - mv example -> src, app.js -> index.js,
      styles.cssm -> styles.module.css, index.html -> public/
      - for some reason the container height didn't go to 100% anymore, so
        I had to change it to 100vh instead
    - change id of 'container' to 'root'
    - use CRA's mostly default public stuff
      - change short name, name, title to RCS Example
      - replace index.html with CRA's for simplicity
    - replace scripts and add config to package.json
    - remove webpack config
    - gitignore build/ dir again and remove gh-pages bundle
    
    (deps): install react-scripts, remove all other devDeps
    agilgur5 committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    2a1b3f6 View commit details
    Browse the repository at this point in the history
Loading