Skip to content

fix(ReActAgent): When ReactAgent resumes, it only executes tools that do not yet have corresponding results#650

Merged
AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
wuji1428:fix-hitl-resume
Jan 24, 2026
Merged

fix(ReActAgent): When ReactAgent resumes, it only executes tools that do not yet have corresponding results#650
AlbumenJ merged 1 commit intoagentscope-ai:mainfrom
wuji1428:fix-hitl-resume

Conversation

@wuji1428
Copy link
Contributor

@wuji1428 wuji1428 commented Jan 23, 2026

AgentScope-Java Version

[The version of AgentScope-Java you are working on, e.g. 1.0.7, check your pom.xml dependency version or run mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]

Description

In the acting function, based on extracting the calling tools from the previous assistant message, tools that already have calling results are filtered out.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

Related Issues

Ref #649

@wuji1428 wuji1428 requested a review from a team January 23, 2026 09:17
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...e/src/main/java/io/agentscope/core/ReActAgent.java 70.00% 1 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@AlbumenJ AlbumenJ merged commit a2760f6 into agentscope-ai:main Jan 24, 2026
5 checks passed
Alexxigang pushed a commit to Alexxigang/agentscope-java that referenced this pull request Jan 25, 2026
… do not yet have corresponding results (agentscope-ai#650)

## AgentScope-Java Version

[The version of AgentScope-Java you are working on, e.g. 1.0.7, check
your pom.xml dependency version or run `mvn dependency:tree | grep
agentscope-parent:pom`(only mac/linux)]

## Description
In the `acting` function, based on extracting the calling tools from the
previous assistant message, tools that already have calling results are
filtered out.

## Checklist

Please check the following items before code is ready to be reviewed.

- [x]  Code has been formatted with `mvn spotless:apply`
- [x]  All tests are passing (`mvn test`)
- [x]  Javadoc comments are complete and follow project conventions
- [x] Related documentation has been updated (e.g. links, examples,
etc.)
- [x]  Code is ready for review

## Related Issues
Ref  [agentscope-ai#649](agentscope-ai#649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants