Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 22.5 wavs #25

Merged
merged 3 commits into from
Jun 20, 2024
Merged

fix 22.5 wavs #25

merged 3 commits into from
Jun 20, 2024

Commits on Jun 20, 2024

  1. Fix 22.5 khz wav files being reported as truncated by some apps 

    The sizes in the "RIFF" and "data" chunks were correct for a 44.1 khz
wav, but the same value was used for 22.1 wav. Fix that by:

- For the "RIFF" chunk: Using a simple algorithm
- For the "data" chunk: Correctly counting the number of samples written

Fixes #22
    @agateau
    agateau committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    031e26c View commit details
    Browse the repository at this point in the history

  2. WavSaver: make code more readable

    @agateau
    agateau committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7c56539 View commit details
    Browse the repository at this point in the history

  3. Clean up WavExportStrategy 

    - No more public members
- All members use mSnakeCase, with more self-explanatory names
- Input-only members are const and passed to the constructor
    @agateau
    agateau committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8c4686c View commit details
    Browse the repository at this point in the history