fix 22.5 wavs #25
Merged
fix 22.5 wavs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
agateau
commented
Jun 20, 2024
agateau
commented
- Fix 22.5 khz wav files being reported as truncated by some apps
- WavSaver: make code more readable
- Clean up WavExportStrategy
The sizes in the "RIFF" and "data" chunks were correct for a 44.1 khz wav, but the same value was used for 22.1 wav. Fix that by: - For the "RIFF" chunk: Using a simple algorithm - For the "data" chunk: Correctly counting the number of samples written Fixes #22
- No more public members - All members use mSnakeCase, with more self-explanatory names - Input-only members are const and passed to the constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.