-
Notifications
You must be signed in to change notification settings - Fork 28
feat: implement DatasetLibrary.names as class property #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 78 78
Lines 3561 3570 +9
Branches 629 629
=========================================
+ Hits 3561 3570 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pylint is complaining:
This one would be easy to fix: either rename What's worse is this:
This means pylint doesn't get that this is a property, not simply a method. I'll try this approach soon: class classproperty(property):
def __get__(self, owner_self, owner_cls):
return self.fget(owner_cls) |
Description
followup to #1022
inspired by https://stackoverflow.com/questions/76249636/class-properties-in-python-3-11
there's really some next level magic involved. need to level up my skill tree.