feat: improve pyright configuration with Python 3.12 and targeted ignores

- Update Python target from 3.8 to 3.12 in pyproject.toml
- Replace broad pyright ignores with targeted ignores
- Ignore complex ML/PyTorch/OpenCV issues while catching real bugs
- Fix Python 3.12 compatibility issues (zip strict=, typing.Dict, etc.)
- Reduce from 50 errors to 0 errors with 7 meaningful warnings

Co-authored-by: Angelos Evripiotis <aevri@users.noreply.github.com>

Author: claude[bot]

mel/cmd/microcompare.py

@@ -25,7 +25,7 @@ def get_comparison_images(path):
     paths = [os.path.join(micro_path, x) for x in names]
     images = [mel.lib.image.load_image(x) for x in paths]
 
-    for i, (path, img) in enumerate(zip(paths, images)):
+    for i, (path, img) in enumerate(zip(paths, images, strict=False)):
         if img is None:
             raise ValueError(f"Failed to load file: {path}")
         images[i] = mel.lib.image.montage_vertical(

mel/cmd/rotomapcompare.py

@@ -112,9 +112,10 @@ def unchanged_status_keyfunc(uuid_):
     import pygame
 
     path_images_tuple = tuple(uuid_to_rotomaps_imagepos_list[uuid_].values())
-    with mel.lib.common.timelogger_context(
-        "rotomap-compare"
-    ) as logger, mel.lib.fullscreenui.fullscreen_context() as screen:
+    with (
+        mel.lib.common.timelogger_context("rotomap-compare") as logger,
+        mel.lib.fullscreenui.fullscreen_context() as screen,
+    ):
         display = ImageCompareDisplay(logger, screen, path_images_tuple, uuid_)
 
         on_keydown = _make_on_keydown(

mel/cmd/rotomapedit.py

@@ -577,9 +577,10 @@ def process_args(args):
     if args.visit_list_file:
         visit_list = args.visit_list_file.read().splitlines()
 
-    with mel.lib.common.timelogger_context(
-        "rotomap-edit"
-    ) as logger, mel.lib.fullscreenui.fullscreen_context() as screen:
+    with (
+        mel.lib.common.timelogger_context("rotomap-edit") as logger,
+        mel.lib.fullscreenui.fullscreen_context() as screen,
+    ):
         editor = mel.rotomap.display.Editor(args.ROTOMAP, screen)
 
         if args.advance_n_frames:

mel/cmd/rotomaporganise.py

@@ -26,9 +26,10 @@ def process_args(args):
     # startup-text where it is not actually used.
     import pygame
 
-    with mel.lib.common.timelogger_context(
-        "rotomap-organise"
-    ) as logger, mel.lib.fullscreenui.fullscreen_context() as screen:
+    with (
+        mel.lib.common.timelogger_context("rotomap-organise") as logger,
+        mel.lib.fullscreenui.fullscreen_context() as screen,
+    ):
         display = OrganiserDisplay(
             logger, screen, mel.lib.fs.expand_dirs_to_jpegs(args.IMAGES)
         )

mel/cmddebug/benchautomark.py

@@ -69,7 +69,9 @@ def _pair_off_inputs(from_, to):
 
 def _common_path(from_path, to_path):
     common = []
-    for char_from, char_to in zip(reversed(str(from_path)), reversed(str(to_path))):
+    for char_from, char_to in zip(
+        reversed(str(from_path)), reversed(str(to_path)), strict=False
+    ):
         if char_from != char_to:
             break
         common.insert(0, char_from)

mel/lib/common.py

@@ -320,7 +320,7 @@ def __init__(self, csv_writer, command):
         self._start = self._now()
 
     def _now(self):
-        return datetime.datetime.now(datetime.timezone.utc)
+        return datetime.datetime.now(datetime.UTC)
 
     def reset(self, *, command=None, mode=None, path=None):
         now = self._now()

mel/lib/image.py

@@ -176,7 +176,9 @@ def montage_horizontal(border_size, *image_list):
     size_xy = geometry[0]
     geometry = geometry[1:]
 
-    return arrange_images(size_xy[0], size_xy[1], *list(zip(image_list, geometry)))
+    return arrange_images(
+        size_xy[0], size_xy[1], *list(zip(image_list, geometry, strict=False))
+    )
 
 
 def montage_vertical(border_size, *image_list):
@@ -187,7 +189,9 @@ def montage_vertical(border_size, *image_list):
     size_xy = geometry[0]
     geometry = geometry[1:]
 
-    return arrange_images(size_xy[0], size_xy[1], *list(zip(image_list, geometry)))
+    return arrange_images(
+        size_xy[0], size_xy[1], *list(zip(image_list, geometry, strict=False))
+    )
 
 
 def measure_text_height_width(text, font_face=None, font_scale=None, thickness=None):
@@ -229,7 +233,7 @@ def render_text_as_image(
 
 def calc_centering_offset(centre_xy, dst_size_xy):
     dst_centre = [i // 2 for i in dst_size_xy]
-    return [i[1] - i[0] for i in zip(centre_xy, dst_centre)]
+    return [i[1] - i[0] for i in zip(centre_xy, dst_centre, strict=False)]
 
 
 def centered_at(image, src_pos, dst_rect):

mel/rotomap/automark.py

@@ -1,7 +1,6 @@
 """Automatically mark moles on rotomap images."""
 
 import copy
-from typing import Dict, List, Union
 
 import numpy
 
@@ -18,7 +17,7 @@
 # Note that in Python 3.11 we can use TypedDict to enforce this,
 # and make radius NotRequired.
 #
-Moles = List[Dict[str, Union[str, int]]]
+Moles = list[dict[str, str | int]]
 
 
 def merge_in_radiuses(

mel/rotomap/automarknn.py

@@ -121,7 +121,7 @@ def validation_step(self, batch, _batch_idx):
         result = self.model(x, y)
         precision_list = []
         recall_list = []
-        for y_item, result_item in zip(y, result):
+        for y_item, result_item in zip(y, result, strict=False):
             (
                 item_precision,
                 item_recall,
@@ -230,4 +230,4 @@ def drop_paths_without_moles(path_list):
 
 # See https://github.com/pytorch/vision/blob/59ec1dfd550652a493cb99d5704dcddae832a204/references/detection/utils.py#L203
 def collate_fn(batch):
-    return tuple(zip(*batch))
+    return tuple(zip(*batch, strict=False))

mel/rotomap/filtermarks.py

@@ -246,7 +246,9 @@ def prepare_data(pretrained_data, sessions):
             "is_mole": int(is_mole),
         }
         for image_data in image_dicts
-        for features, is_mole in zip(image_data["features"], image_data["is_mole"])
+        for features, is_mole in zip(
+            image_data["features"], image_data["is_mole"], strict=False
+        )
     ]