Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the design issues in MeasurableTransform #206

Open
brandonwillard opened this issue Nov 30, 2022 · 0 comments
Open

Fix the design issues in MeasurableTransform #206

brandonwillard opened this issue Nov 30, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed refactoring A change that improves the codebase but doesn't necessarily introduce a new feature rv-transforms Involves transforms applied to random variables

Comments

@brandonwillard
Copy link
Member

Currently, MeasurableTransform keeps a fixed set of valid_scalar_types consisting of supported scalar Ops. This needs to be completely changed so that supported Ops can be extended in a reasonable way, and without the need to import/specify them in AePPL itself, or perform hackish updates to static lists in AePPL classes.

The entire approach needs to be reconsidered carefully, although the aforementioned improvements are still a good start.
@brandonwillard brandonwillard added enhancement New feature or request help wanted Extra attention is needed rv-transforms Involves transforms applied to random variables refactoring A change that improves the codebase but doesn't necessarily introduce a new feature labels Nov 30, 2022
@brandonwillard brandonwillard mentioned this issue Dec 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed refactoring A change that improves the codebase but doesn't necessarily introduce a new feature rv-transforms Involves transforms applied to random variables
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandonwillard