Add tests for AddOperation and RmOperation

Author: Gabriel Kim

src/json_logic.cpp

@@ -92,6 +92,16 @@ namespace json_logic
 			values = json::array({values});
 		}
 
+		/**
+		* In JsonLogic, operation names are treated as keywords and will result in one of the known operations being
+		* invoked with the provided logic and data objects. Logic objects with unrecognized operations are treated as
+		* "useless statements" that just returns its own values, such as:
+		*
+		* myLogic; // Returns myLogic.
+		*
+		* This is an important behaviour for the operation_array_merge, which can receive arbitrary JSON objects in its
+		* parameters and is expected to just return them as elements of a flattened array.
+		*/
 		const auto operation_it = operations_.find(op);
 
 		if (operation_it != operations_.end())

test/CMakeLists.txt

@@ -5,6 +5,7 @@ set(TEST_TARGET ${PROJECT_NAME}_test)
 add_executable(
         ${TEST_TARGET}
 
+        add_rm_operation.cpp
         operations/array/all.cpp
         operations/array/filter.cpp
         operations/array/in.cpp

test/add_rm_operation.cpp

@@ -0,0 +1,78 @@
+#include <iostream>
+
+#include "gtest/gtest.h"
+#include "json.hpp"
+
+#include "fixture.h"
+
+using namespace nlohmann;
+
+class AddRmOperation : public testing::Test
+{
+ protected:
+  JsonLogic* json_logic_;
+
+  void SetUp() override
+  {
+	json_logic_ = JsonLogic::GetInstance();
+
+	json_logic_->AddOperation("myOperation", [this](const json& values, const json& data) {
+	  const double a = json_logic_->Apply(values.at(0), data);
+	  const double b = json_logic_->Apply(values.at(1), data);
+
+	  return a + b;
+	});
+  }
+};
+
+TEST_F(AddRmOperation, AddOperationPrimitive) {
+	const auto logic = R"(
+		{
+			"myOperation": [1, 2]
+		}
+	)"_json;
+
+  const auto result = json_logic_->Apply(logic);
+
+  EXPECT_EQ(result, 3);
+}
+
+TEST_F(AddRmOperation, AddOperationData)
+{
+  const auto logic = R"(
+		{
+			"myOperation": [
+				{ "var": ["foo.bar"] },
+				{ "var": ["foo.baz"] }
+			]
+		}
+	)"_json;
+
+  const auto data = R"(
+		{
+			"foo": {
+				"bar": 1,
+				"baz": 2
+			}
+		}
+	)"_json;
+
+  const auto result = json_logic_->Apply(logic, data);
+
+  EXPECT_EQ(result, 3);
+}
+
+TEST_F(AddRmOperation, RmOperation)
+{
+  json_logic_->RmOperation("myOperation");
+
+  const auto logic = R"(
+		{
+			"myOperation": [1, 2]
+		}
+	)"_json;
+
+  const auto result = json_logic_->Apply(logic);
+
+  EXPECT_EQ(result, logic);
+}