Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT,DEP] _binary.py metrics deprecated #2600

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

aryanpola
Copy link
Contributor

Reference Issues/PRs

Related to #2576 . See also #2400 .

What does this implement/fix? Explain your changes.

Deprecates range metrics functions from C:\Users\aryan\aeon\aeon\benchmarking\metrics\anomaly_detection\_binary.py.

@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#264F59}{\textsf{benchmarking}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst
Copy link
Member

While its not a rule to fill out the template completely, at least follow the guidance please.

@MatthewMiddlehurst MatthewMiddlehurst added maintenance Continuous integration, unit testing & package distribution deprecation This issue is related to deprecation or removal of code labels Mar 15, 2025
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but it would be 1.2.0 not 1.1.0

@aryanpola
Copy link
Contributor Author

Looks fine but it would be 1.2.0 now 1.1.0

Updated.

@aryanpola aryanpola changed the title _binary.py metrics deprecated [MNT,DEP] _binary.py metrics deprecated Mar 16, 2025
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@MatthewMiddlehurst MatthewMiddlehurst merged commit 55f5724 into aeon-toolkit:main Mar 18, 2025
16 checks passed
@aryanpola aryanpola deleted the deprecate branch March 19, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarking Benchmarking package deprecation This issue is related to deprecation or removal of code maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants