-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify documentation regarding unequal length series limitation #2589
Conversation
Thank you for contributing to
|
My bad, see latest issue comment. |
The first PR was more accurate, but we do not need a large warning IMO. Perhaps just tidy the first paragraph and change the part about np-list to reflect that it does not have to be unequal length (but that is its primary usage). The capabilities paragraph below that is sufficient but if you think it can be improved go ahead. |
@MatthewMiddlehurst I have made the changes please review and let me know if any changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The capabilities part is repetitive IMO. The problem part is (any number of channels, unequal length series)
, removing that is probably enough TBH. If you think it can be improved further feel free to make suggestions, but we do not want to bloat it.
kept |
Please try to avoid force pushing like this if you can. |
or give us a hand in finding out why doing so breaks pre-commit testing i guess 🙂 |
Apologies! I usually force push to keep a single commit in a PR that contains all the changes made so far. Is this not a recommended approach? What would you suggest as a best practice in the open-source world 😊? |
Beside breaking our CI, having a change log of commits is helpful for reviewing. Please just merge or rebase in the future. These are all squished on merge into a single commit either way. |
Reference Issues/PRs
Fixes: #2444
What does this implement/fix? Explain your changes.
This PR updates the documentation to clarify the supported input data formats for the collection transformers module
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access