[DDP] Remove self.modules_params (pytorch#64473)

rohan-varma · facebook-github-bot · commit 8c095102948c · 2021-09-08T19:16:13.000-07:00
Summary: Pull Request resolved: pytorch#64473 Unused after SPMD deprecated. ghstack-source-id: 137526305 Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D30745961 fbshipit-source-id: 32d102502570291e01579e5b47a6d74dc71013bb
diff --git a/torch/nn/parallel/distributed.py b/torch/nn/parallel/distributed.py
@@ -734,9 +734,6 @@ def produces_sparse_gradient(module):
             for replica in modules_and_parameters
         ]
 
-        # The following modules_params and modules_buffers are used for
-        # param/buffer sync in _sync_params.
-        self.modules_params = [list(self._get_parameters(self.module))]
         self._assign_modules_buffers()
 
         return parameters, expect_sparse_gradient

Original file line number	Diff line number	Diff line change
`@@ -734,9 +734,6 @@ def produces_sparse_gradient(module):`
`734`	`734`	`for replica in modules_and_parameters`
`735`	`735`	`]`
`736`	`736`
`737`		`- # The following modules_params and modules_buffers are used for`
`738`		`- # param/buffer sync in _sync_params.`
`739`		`- self.modules_params = [list(self._get_parameters(self.module))]`
`740`	`737`	`self._assign_modules_buffers()`
`741`	`738`
`742`	`739`	`return parameters, expect_sparse_gradient`