Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afterMethodCallOnServiceQueue is not called after service method call #761

Open
lijishuai opened this issue Sep 5, 2016 · 4 comments
Open

Comments

@lijishuai
Copy link

lijishuai commented Sep 5, 2016

setAfterMethodCallOnServiceQueue(..) , but not called.
I find the problem in function BaseServiceQueueImpl.doHandleMethodCall(...)
If the service method return ServiceConstants.VOID , afterMethodCall will be lost.
I think something is wrong when I set afterMethodCall... but not be invoked.
I find the receiver handler of ServiceQueue's responseQueue does not invoke afterMethodCall in function CallbackManagerWithTimeout's method handleResponse(...)
thanks.

@RichardHightower
Copy link
Member

Do you want to try a patch? PR?

@lijishuai
Copy link
Author

I can do it, but maybe after some days. because I'm very busy on work now. so ...
I have some other advice on sync -> async call when refactor old sync source code. will new a issue.

@RichardHightower
Copy link
Member

Ok.. Sounds good. I look forward to the PR. Thanks for using QBit and keep the feedback coming.

@RichardHightower
Copy link
Member

If you don't have time for a PR, try at least a code sample or unit test that shows the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants